Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulkan feature exclude macOS and iOS by default #3292

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Dec 14, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Closes #3287

Description

  • vulkan feature exclude macOS and iOS by default, users can use vulkan-portability feature to enable vk backend.
  • player can be re-runnable locally.

Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown will cause error, but this is another issue:

error: No back ends enabled in `wgpu-hal`. Enable at least one backend feature.
  --> wgpu-hal/src/lib.rs:59:1
   |
59 | compile_error!("No back ends enabled in `wgpu-hal`. Enable at least one backend feature.");
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: could not compile `wgpu-hal` due to previous error

Testing
Tested locally

@cwfitzgerald
Copy link
Member

Ah, so this is because the command is explicitly trying to build wgpu-hal on wasm, which doesn't make any sense right now. We should specify to run with -p wgpu.

wgpu/Cargo.toml Outdated Show resolved Hide resolved
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) January 4, 2023 21:27
@cwfitzgerald cwfitzgerald merged commit 33e5b7a into gfx-rs:master Jan 4, 2023
@jinleili jinleili deleted the vk-portability branch January 26, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MacOS] shadow example not working correctly anymore on MacOS
2 participants